Skip to content

hareThirdParty.hare-toml: init at 0.1.0#271761

Merged
pbsds merged 1 commit intoNixOS:masterfrom
onemoresuza:hare-toml
Dec 30, 2023
Merged

hareThirdParty.hare-toml: init at 0.1.0#271761
pbsds merged 1 commit intoNixOS:masterfrom
onemoresuza:hare-toml

Conversation

@onemoresuza
Copy link
Contributor

@onemoresuza onemoresuza commented Dec 2, 2023 •
edited
Loading

Description of changes

Initialize hare-toml, an implementation of the TOML format for Hare, at 0.1.0.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@onemoresuza
Copy link
Contributor Author

onemoresuza commented Dec 2, 2023 •
edited
Loading

Before this PR is ready for review, #271476 must be merged.

#271476 was merged.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 2, 2023
@onemoresuza onemoresuza force-pushed the hare-toml branch 2 times, most recently from 0cc94ff to 102c414 Compare December 5, 2023 23:17
@onemoresuza onemoresuza changed the title hare-toml: init at 0.1.0 hareThirdParty.hare-toml: init at 0.1.0 Dec 5, 2023
@onemoresuza onemoresuza marked this pull request as ready for review December 15, 2023 10:13
@onemoresuza onemoresuza force-pushed the hare-toml branch 2 times, most recently from a4e06aa to 2f50d67 Compare December 15, 2023 16:33
@nixos-discourse
Copy link

nixos-discourse commented Dec 16, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3109

SuperSandro2000
SuperSandro2000 reviewed Dec 16, 2023
View reviewed changes
@onemoresuza onemoresuza force-pushed the hare-toml branch 6 times, most recently from a67b572 to d2d89fa Compare December 21, 2023 20:57
@onemoresuza onemoresuza added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 24, 2023
@nixos-discourse
Copy link

nixos-discourse commented Dec 24, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1337

@onemoresuza onemoresuza removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 24, 2023
@onemoresuza onemoresuza added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Dec 24, 2023
@onemoresuza onemoresuza requested a review from pbsds December 29, 2023 01:27
pbsds
pbsds approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 271761 run on x86_64-linux 1

1 package built:
  • hareThirdParty.hare-toml

Patches are merged into master, and the build logs, derivation and build results LGTM. Thanks!

@pbsds pbsds merged commit 9257497 into NixOS:master Dec 30, 2023
@onemoresuza onemoresuza deleted the hare-toml branch December 30, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

+1 more reviewer

@starzation starzation starzation approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@onemoresuza @nixos-discourse @pbsds @SuperSandro2000 @starzation